DAGMan errors if "@" in log file path
Log file names in DAGMan are templated by injecting variable names and substituting values using @(DAG_DIR), @(DAG_FILE), etc. After substitution occurs, DAGMan checks for any additional @ that still exist in the log file name and emits a warning if any are found. This becomes a problem on submit machines where home directories are configured to be created using (for example) full authenticated names from Active Directory:
This causes DAGMan to emit a (fatal if DAGMAN_USE_STRICT = 1, as it is by default and should be) warning:
Instead, either a regex check should be used, looking for unmatched @([^)]*) or even just a simple check for @( should be used instead of a bare @.
CODE REVIEW looks good