ID Tokens memory leak


Address sanitizer reports the following:


Todd Tannenbaum
March 17, 2021, 2:28 PM

With this patch, we believe the memory leak is fixed in the common case of an update successfully sent to the collector. We think a leak still occurs, in the uncommon case that an update is unsuccessful (e.g. the collector is temporarily down). This will have to be another ticket for another day.

Code review issues addressed and version history done, resolving.

Greg Thain
March 9, 2021, 6:51 PM

CODE REVIEW I checked that this passes asan. Code quibble – unique_ptr.release returns the original pointer, so instead of



Can we instead do the following, so if we change the code in the future we don’t encourage problems?


Todd Tannenbaum
March 9, 2021, 5:43 PM

For a review of the code, only the last three commits are relevant. So do

Time remaining



Todd Tannenbaum