ID Tokens memory leak
Address sanitizer reports the following:
With this patch, we believe the memory leak is fixed in the common case of an update successfully sent to the collector. We think a leak still occurs, in the uncommon case that an update is unsuccessful (e.g. the collector is temporarily down). This will have to be another ticket for another day.
Code review issues addressed and version history done, resolving.
CODE REVIEW I checked that this passes asan. Code quibble – unique_ptr.release returns the original pointer, so instead of
Can we instead do the following, so if we change the code in the future we don’t encourage problems?
For a review of the code, only the last three commits are relevant. So do