Job Router umbrella constraints erroneously contain an Owner constraint
This causes the condor_job_router_info -match-jobs tool to not return any results:
condor_job_router_info still includes the Owner constraint when run as a non-root user. That seems needlessly user hostile for admins. Consider leaving it out be default (with option to add it by request). That can be another ticket.
Otherwise, the code looks good.
git commit incorrectly shows this as a commit
There is a separate bug that when a Linux user runs the job router tool as root, && (target.Owner == "root") is added as a final clause to the umbrella constraint. this will never match any jobs, and will not be added by the job router itself.
The problem is the Umbrella constraint has this clause at the end && (target.Owner == "blin") when blin is the user that runs the tool. This is misleading because that clause will not be there if the JobRouter is running as root/condor.