DAGMan direct submit needs to report commit failure

Description

In gittrac #7568 we improved the messaging related to DAGMan direct job submission (where it writes job ads directly to the schedd, instead of forking condor_submit).

However there are still times when errors do not get reported as expected. In particular, when a direct job submission fails because it does not meet the submit requirements, it fails silently. No error gets written to the log. We need to catch these failure and report them.

Activity

Show:
John (TJ) Knoeller
March 22, 2021, 3:54 PM

CODE REVIEW : all changes now look good.

John (TJ) Knoeller
March 15, 2021, 8:33 PM

CODE REVIEW DisconnecQ will always return false when the second argument is false, and will never set anything into the errstack in that case, so that dprintf probably should not exist.

Mark Coatsworth
March 15, 2021, 6:46 PM

This was a copy-paste error, I just fixed it.

John (TJ) Knoeller
March 15, 2021, 5:41 PM

CODE REVIEW the second DisconnectQ call changed from cancelling the transaction to committing it.

Due date

2021/01/08

Time remaining

0m

Assignee

Mark Coatsworth